Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some issue with suggestion box #48

Merged
merged 5 commits into from
Jan 17, 2025
Merged

Fix some issue with suggestion box #48

merged 5 commits into from
Jan 17, 2025

Conversation

dab246
Copy link
Owner

@dab246 dab246 commented Jan 15, 2025 •
edited
Loading

Fix some issue

  • Fix the issue where the suggestionsBoxMaxHeight property is not working correctly
  • Support load more items in suggestion box
  • Scroll to top suggestion list when value change
  • Keep the order of items in the suggestion list when loading more
  • Auto load more when user uses arrow down of keyboard

@dab246 dab246 mentioned this pull request Jan 15, 2025
Merged
@hoangdat
Copy link

hoangdat commented Jan 15, 2025 •
edited by dab246
Loading

  • should listen keyboard down, when it reaches to the last item, load more also
  • list will move down/up, when user uses arrow down/up

@dab246 dab246 force-pushed the fix-some-issue-with-suggestion-box branch from fb410c8 to 3ac885e Compare January 16, 2025 05:22
@dab246
Copy link
Owner Author

dab246 commented Jan 16, 2025

  • should listen keyboard down, when it reaches to the last item, load more also
  • list will move down/up, when user uses arrow down/up

Done.

Screen.Recording.2025-01-16.at.12.18.39.mov

@hoangdat
Copy link

please merge this and apply it to tmail

@dab246 dab246 force-pushed the fix-some-issue-with-suggestion-box branch from 3ac885e to effd7bd Compare January 17, 2025 07:01
@dab246 dab246 merged commit 1094c50 into master Jan 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoangdat hoangdat hoangdat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dab246 @hoangdat